[Patch, fortran] PR37159

[Thomas Koenig]

On Tue, 2008-09-09 at 00:59 +0200, Dennis Wassel wrote:

Hi Dennis,

> I have worked on coding style (taking the liberty to adapt some
> existing comments in check.c) and replaced the HAVE_GFC_REAL_16 by
> gfc_validate_kind() in check.c, as Tobias suggested.
> 
> Currently regression-testing on my x86-32-linux. Takes >1h (big >) on
> my Virtualbox - is this normal or just virtualisation slowing things
> down?

This is normal; we cycle through a lot of test cases, and most of them
run through quite a lot of option iterations.

> As Thomas Koenig suggested, this should also be tested on a system
> which has REAL(16), but I don't have access to one, and using the
> compile farm doesn't look trivial enough to just give it a spin -
> could someone with such a system do me that favour? Thanks a lot!

I've finally gotten a bootstrap working on the compile farm on a
real(16) system, a sparc64-unknown-linux-gnu (which took me some time)
and your test program does indeed work as advertised there.

I also regression-tested you patch on x86_64-unknown-linux-gnu (thanks
to the gcc compile farm), without regressions.

Good work!

> Speaking of testing: I still have not come up with a solution to
> telling systems with REAL(10) and (16) apart in the testsuite. Further
> ideas?

Unfortunately, not.

> I cannot convince my mailer to attach the f90-file as MIME-type text -
> should I use a "rename trick" (i.e. add .txt suffix) or is this fine
> with everybody?

The way it is right now is quite OK.

> And lastly: Is this the proper way to do the Changelog?

Almost:

> gcc/Changelog:
> 2008-09-09  Dennis Wassel  <dennis.wassel@googlemail.com>

Empty line missing here.

> 	PR fortran/37159
> 	* fortran/check.c (gfc_check_random_seed): Check size of PUT array at
> compile time.

Try to make the lines a bit shorter.

The patch is OK for trunk once your copyright papers are through.
Can you drop us a line when that happens?  I'll commit your patch for
you then.

Congratulations on your first patch, and welcome aboard!

	Thomas