Infamous PR fortran/19925

[Steve Kargl]

On Sun, Sep 14, 2008 at 09:57:05PM +0200, Dominique Dhumieres wrote:
> Thanks for the patch which a step in the right direction.
> It worked as expected on my tests replacing an unneeded ICE
> by an error. I have the following comments:
> 
> (1) Why restrict max-array-constructor to values above 65535?
> Some users may want to set it to a lower value to abort the
> compilation sooner. BTW it seems that values lower than 65535
> are silently set to it.

We need to set some minimum, so I simply chose to retain 65535,
which is the default value.  Allowing -fmax-array-constructor=1
certainly makes little sense.

> (2) Could the error message be more user friendly?
> (a) is the locus of the error lost when it is emitted?

I'll see if the locus is available.

> if not it would be nice to have the location of the offending
> constructor (or any other info about it).
> (b) I think the maximum size should be given in the error message.
> (c) "Array constructor expansion" may be difficult to understand
> for lay users. Why not something such as "The number of elements
> in a constructor is greater than the maximum value 65535 ..."
> (or whatever you like to fix my Frenglish).

I'll see if I can come up with a better error message.

-- 
Steve