[Patch, Fortran] PR fortran/37199: Wrong code for function returning array
Daniel Kraft
d@domob.eu
Mon Sep 8 09:22:00 GMT 2008
Paul Richard Thomas wrote:
> When I wrote gfc_map_intrinsic_function, I completely forgot about
> such simple safety nets:-( Would you cast a quick eye over the rest
> of the function to see if any similar limits have been forgotten,
> please? I don't think so but four eyes are better than two!
I've added another check for NULL bounds (for ISYM_?BOUND), just to make
sure. Otherwise it seemed ok.
> OK for trunk and 4.3, after the usual, decent interval.
Committed to trunk as revision 140102, will commit to 4.3 in some days.
> Thanks for the patch - I wonder why the array_spec was not added to
> new_sym in the first place?
I've of course no idea, but I think it was simply forgotten; if there
were a good reason, I think there would have been a comment and maybe an
explicit NULL assignment (at least that's how I would've done it).
Thanks for the review,
Daniel
--
Done: Arc-Bar-Cav-Sam-Val-Wiz, Dwa-Elf-Gno-Hum-Orc, Law-Neu-Cha, Fem-Mal
To go: Hea-Kni-Mon-Pri-Ran-Rog-Tou
More information about the Fortran
mailing list