[Patch, Fortran] PR fortran/35723: Some fixes to restricted-expression handling

[Daniel Kraft]

Dominique Dhumieres wrote:
> Daniel,
> 
>> and commit in addition Dominique's test to prevent regressing in the future.
> 
> First the test I have sent has been extracted from pr36192 in order to show 
> the lost errors.
> 
> Second, I don't think this test is needed if you remove the error "suppressors" 
> from your patch. I think it would be more appropriate in the patch fixing the 
> duplicate errors.

Hi Dominique,

my point was to ensure these regressions don't occur at any point in the 
future, as (see my reasoning else-thread for that) I believe 
is_non_constant_shape_array is not really "right" in reporting errors 
and we may come across other problems with those; just speculating, though.

However, I don't think your test would be more appropriate with the 
patch for fixing the duplicate errors than it is now; my understanding 
is that the lost errors are more or less a bug uncovered (or at least 
something I would consider bad design) and neither related to either of 
the two patches...

But I'll do whatever you believe is best here.

Daniel

-- 
Done:  Arc-Bar-Cav-Rog-Sam-Val-Wiz
To go: Hea-Kni-Mon-Pri-Ran-Tou