PING: [patch, fortran] PR 27997: Implement F2003-style array constructor with typespec

FX fxcoudert@gmail.com
Sat May 10 15:09:00 GMT 2008


> Here comes an updated patch (and changelog, but that was not  
> changed) having the tabs only in C source and not in the test- 
> cases.  Hope this is ok now, sorry for the misunderstanding.   
> (Nothing else was changed after the last submitted patch).

Thanks for the updated patch.

> BTW, I found that in trans-array.c there's lots of code already  
> existing that is intended by eight spaces rather than tabs (array.c  
> was without); I could trivially work out a patch fixing these  
> issues in the code (search&replace).  Are such patches welcome, or  
> is "reformatting" nothing you want?

There are conflicting goals here: reformating is nice, but  
reformating a large part of code will make applying previously made  
diffs (and merging branches and local modifications) harder. So, I  
think it's a good thing to do, but we should try to do it locally  
(i.e. when you change a part of code, reformat it is always fine) or  
closer to release (when people don't tend to have large diffs lying  
around).


FX

-- 
François-Xavier Coudert
http://www.homepages.ucl.ac.uk/~uccafco/



More information about the Fortran mailing list