PING: [patch, fortran] PR 27997: Implement F2003-style array constructor with typespec

[Daniel Kraft]

>> I did run the tests through the framework, so this is not the problem. 
>> I'm not sure about tab-characters in the patch; shouldn't there be 
>> any?  (Are they disallowed in Fortran for indentation or something 
>> like this?)
>>
>> What I did do was replacing every eight spaces indentation by tabs as 
>> I was told this is the way to go for GCC source; or should I do this 
>> only for real C sources and not for testcases?
> Regarding test cases: There is no real formatting standard with regards 
> to test cases, use whatever you like - as long it is valid Fortran 
> (unless you test the error/warning diagnostics).
> 
> Regarding tabs in Fortran: Official Fortran characters are: A-Z (which 
> are equivalent to a-z), 0-9, underscore, blank, and other special 
> characters, but not the tab character. (See section 3.1 in the Fortran 
> 2003 standard.) Other characters are allowed in comments, character 
> literals and I/O (records, edit descriptors).

I see, thanks for the information!

> As tabs are extensions, -pedantic warns if it sees one. By default the 
> test suite uses the option "-pedantic", unless one overwrites this 
> option using "{ dg-options "" }".
> 
> I think the test case should have failed if you had put it into the 
> testsuite/gfortran.dg/ directory before calling "make check-gfortran". 
> To run only a single test, you can use

Actually, I did replace the spaces by tabs in the patch file as I've
configured my vim to expand tabs to spaces and don't want to mess around
reconfiguring it to adjust to the GNU style (unless there's an easy way
to do so, but I'm no vim guru).

So on my system they had spaces instead of tabs, only the patch was
messed up.  Sorry for that, I'll insert tabs only in C source files for
the future (but there they belong, right?)

Should I send an updated patch?  Are there maybe some other things to
adapt on the way or does it seem ok otherwise?

Daniel

-- 
Done:     Bar-Sam-Val-Wiz, Dwa-Elf-Hum-Orc, Cha-Law, Fem-Mal
Underway: Ran-Gno-Neu-Fem
To go:    Arc-Cav-Hea-Kni-Mon-Pri-Rog-Tou