[PATCH] Fortran: PR/34908, PR/36276: do not free current_file->filename if it changes

Laurynas Biveinis laurynas.biveinis@gmail.com
Fri Jun 20 13:46:00 GMT 2008


2008/6/20 Daniel Franke <franke.daniel@gmail.com>:
>> 2008-06-20  Laurynas Biveinis  <laurynas.biveinis@gmail.com>
>>
>>         PR fortran/34908, fortran/36276
>>         * scanner.c (preprocessor_line):  Do not call gfc_free for
>>         current_file->filename if it differs from filename.
>
> Make this
>         PR fortran/34908
>         PR fortran/36276
> to make everybody happy :)

OK, committing to the trunk and to the 4.3 after test there...

> Btw, this might be a cure for PR36342 as well. I'll try to check if I
> can find the time ...

I checked that PR and the valgrind output is clean now, and the
valgrind backtrace in comment #1 definitely points to the same issue.
I did not test without the patch to see those errors though. I will
add note to that PR after commit. I cannot decide that this PR could
be closed as well, as probably real file names in diagnostics should
be reported instead of /tmp/... . This would require exactly the
change the FIXME in the patch suggests.

Thanks,
-- 
Laurynas



More information about the Fortran mailing list