[PATCH, Fortran] Parse FINAL procedure declarations

[Daniel Kraft]

Tobias Burnus wrote:
> Daniel Kraft wrote:
>> attached is the updated patch addressing these comments and ChangeLog.
>> As usual tested on GNU/Linux-x86-32.
>>
>> * Add the not-implemented-error when everything else is finished and
>> ready for check-in, up to then marked XXX.
> This is crucial if you want to have this checked in.

Hi Tobias,

of course, I was just waiting for everything else to be finished ;)

>> * I'm still waiting for the answer to whether I should make f2k_derived
>> a union with formal in gfc_symbol.  My opinion is that this probably
>> does not save that much space and makes things a bit "uglier", but there
>> are already some unions like that in gfortran and it should work
>> perfectly fine.  So I'm waiting for your comments, also for now marked 
>> XXX.
> 
> I believe the patch is OK - except for the missing not-implemented 
> error. Regarding the point above, I don't have strong feelings about it. 
> For me it is fine to delete the comment or leave it as it (including the 
> question mark) with s/XXX/TODO/.
> 
> I will check in your patch, when you provide an patch which gives a 
> not-implemented error. One could think of deferring some of the test 
> cases until the actual implementation is there, if it gets too 
> cumbersome to accommodate them for the not-implemented error.

Thanks, that would be great!  Find attached the new patch, with the two
small corrections as above:

* Added the not-implemented error and adapted test-cases for now (I hope 
I managed to get them right).

* Left the comment about making union in, changed to TODO.  If you come
to a decision, I will change the code accordingly, maybe for part 2 of
the patch.

Cheers,
Daniel

-- 
Done:     Bar-Sam-Val-Wiz, Dwa-Elf-Hum-Orc, Cha-Law, Fem-Mal
Underway: Ran-Gno-Neu-Fem
To go:    Arc-Cav-Hea-Kni-Mon-Pri-Rog-Tou

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch.changelog
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20080602/8d1a630b/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch.diff
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20080602/8d1a630b/attachment-0001.ksh>