[Patch, Fortran] PR36705: Procedure pointers with attributes statements

Janus Weil jaydub66@googlemail.com
Thu Aug 14 19:56:00 GMT 2008


2008/8/14 Tobias Burnus <burnus@net-b.de>:
> Is it only me who finds the preposion "in" strange in:
>
> +      gfc_error ("PROCEDURE attribute conflicts with SAVE attribute "
> +                "in '%s' at %L", sym->name, &sym->declared_at);
> +      return FAILURE;

Well, I really just copied the error message from check_conflict, to
minimize modifications in the testsuite. If I were to choose an error
message, I'd probably pick something like

Procedure %s at %L may not have SAVE attribute.

I think talking of PROCEDURE as an attribute is misleading, especially
when the symbol is actually declared as a FUNCTION or SUBROUTINE. If
you also prefer the above (or something similar) over the old message,
I could change it in my patch before committing. Though I would not
want to change the message in check_conflict for now.

Cheers,
Janus



More information about the Fortran mailing list