[patch,fortran] F2003 Inquire features

Jerry DeLisle jvdelisle@verizon.net
Mon Apr 7 22:18:00 GMT 2008


On Mon, 2008-04-07 at 23:14 +0200, Tobias Burnus wrote:
> > Attached is the final patch of this installment.
> 
> Thanks for the patch!
> 
> > Regression tested and NIST tested.  I am still working up test cases to
> > add.
> > 
> > OK to commit?
> 
> OK after fixing the issues mentioned below.
> 
> Index: gcc/fortran/io.c:
> | 
> |        if (open->encoding->expr_type == EXPR_CONSTANT)
> |  	{
> | -	  static const char * encoding[] = { "UTF-8", "DEFAULT", NULL };
> | +	  static const char * encoding[] = { "DEFAULT", NULL };
> 
> Add a TODO: UTF-8 there. (In the library there is already such a TODO.)
> 
> 

Done

> Index: libgfortran/io/inquire.c:
> +	  case ROUND_UNSPECIFIED:
> +	    p = "UNSPECIFIED";
> +	    break;
> 
> This is wrong.
> 

Well not really wrong, but it is dead code. This is just translating the
incoming specifier to the corresponding string.  That specifier never
happens since it is set to ROUND_PROCDEFINED elsewhere.  So inquire
actually returns "PROCESSOR_DEFINED" right now.

I deleted the dead code.

Patch committed. I am working some test cases now to be sutable for the
testsuite.

Thanks for reviews and comments.

Jerry



More information about the Fortran mailing list