[fortran patch] Don't use TREE_LISTs for storing arguments to intrinsic functions

Lee Millward lee.millward@gmail.com
Mon May 28 22:13:00 GMT 2007


On 5/28/07, Lee Millward <lee.millward@gmail.com> wrote:
> On 5/28/07, FX Coudert <fxcoudert@gmail.com> wrote:
> > I think the for-loop at then end of that hunk should start with i =
> > 1. Otherwise, the generated code for MAX(a,b) start with comparing "a
> >  > a". Can you check that?
> >
> > FX
> >
>
> Sure, I'll check it out later on and report back here.
>
> Cheers,
> Lee
>

I've checked the code being generated for the MAX instrinsic as you
asked and it was generating wrong-code for this case. I've verfied
that the change you suggested does fix the problem so will
rebootstrap/test and get the new patch out sometime tomorrow.

Do you happen to have a testcase that highlighted this problem? It may
be worth adding to the testsuite as non of the existing tests caught
this.

Cheers,
Lee.



More information about the Fortran mailing list