[Patch, fortran] PR29786 - [4.1/4.2/4.3 Regression] Initialization of overlapping variables: Not implemented

Brooks Moses brooks.moses@codesourcery.com
Fri May 25 07:38:00 GMT 2007


Steve Kargl wrote:
> On Thu, May 24, 2007 at 11:04:02PM -0700, Brooks Moses wrote:
>> I have been thinking about it, though.  It's quite possible to backport 
>> most of the target-memory stuff without touching the existing code much 
>> at all, at the cost of having a little bit of extra code duplication 
>> between the Fortran front end and the middle end.  (On mainline, the 
>> right thing to do was to consolidate the duplicated parts into shared 
>> functions.  On a release branch, I believe the right thing is to leave 
>> them separate, so as not to muck about with things more than is needed.) 
>>  Thus, this should be a low-risk backport, despite the size of the patches.
>>
>> Comments?
> 
> On a release branch, we (the gfortran gang) have been somewhat 
> cavalier with backporting with respect to release branch
> rules (If it's a bug, we fix it).  I doubt you'll be able to
> get the non-fortran code into the release branch without much
> discussion.  

I agree -- and I think that most of the non-Fortran code _shouldn't_ go 
in in the form that it's on mainline.

The sole exception to that is very tiny, and obviously harmless.  I'll 
ask about it once I've regtested it.

> If you can keep everything within the fortran
> front-end code, then I'd support the backport (although it
> isn't technically a regression).

Do you mean that the TRANSFER simplification isn't technically a 
regression, or that PR 29786 isn't one?  A good part of the code (and, 
in particular, the small piece that _does_ need to go into the middle 
end) is necessary for fixing either bug, and can be justified on the 
basis of either.

Also, we know that some of the target-memory.c code needs a bit of time 
to settle and get properly tested, and is likely to have some kinks with 
REAL(10) and padding in derived types that need to be worked out. Would 
it be better to wait until that's all fixed in 4.3, or go ahead and 
apply the current version to 4.2 and backport all the patches to it, at 
least until we get close to the 4.2.1 release?

- Brooks



More information about the Fortran mailing list