[patch, fortran] PR18923 segfault after subroutine name confusion

[Jerry DeLisle]

Tobias Burnus wrote:
> :REVIEWMAIL:
> 
> Jerry DeLisle wrote:
>> This patch is self explanatory and eliminates the segfault for two
>> test cases given.  Regression tested on x86-64-gnu-linux.
>> OK for trunk and later 4.2.1
> Ok, but could you also commit the two testcases of PR18923, just to make
> sure the bug does not creep in again.
> 
> 
> Tobias
> 
I would like to add this one additional change.  We need to give it up at some 
point and one of these test cases triggers this.  It seems to make sense to me. 
  Let me know if this is OK and I will include it.  Regression tested of course 
and it obviously passes.

Index: symbol.c
===================================================================
*** symbol.c    (revision 124927)
--- symbol.c    (working copy)
*************** gfc_get_default_type (gfc_symbol * sym,
*** 211,217 ****
                         "implicitly typed variables");

     if (letter < 'a' || letter > 'z')
!     gfc_internal_error ("gfc_get_default_type(): Bad symbol");

     if (ns == NULL)
       ns = gfc_current_ns;
--- 211,217 ----
                         "implicitly typed variables");

     if (letter < 'a' || letter > 'z')
!     gfc_fatal_error ("Symbol name confusion at %C");

     if (ns == NULL)
       ns = gfc_current_ns;