[fortran, patch] PR32467 - structure containing allocatable array is wrongly accepted

Jakub Jelinek jakub@redhat.com
Sun Jun 24 19:25:00 GMT 2007


On Sun, Jun 24, 2007 at 08:39:07PM +0200, Daniel Franke wrote:
> 
> As allocatable components in derived types are not part of F95, OpenMP v2.5 
> does not allow such in clauses where allocatable arrays are not allowed. 
> These clauses are: COPYIN, COPYPRIVATE, FIRSTPRIVATE, LASTPRIVATE, REDUCTION.
> 	
> 
> :ADDPATCH fortran:
> 
> 2007-06-24  Daniel Franke  <franke.daniel@gmail.com>
> 
> 	PR fortran/32467
> 	* openmp.c (resolve_omp_clauses): Emit error on allocatable components 
> 	in COPYIN, COPYPRIVATE, FIRSTPRIVATE, LASTPRIVATE and REDUCTION clauses.

Looks good to me.

> 2007-06-24  Daniel Franke  <franke.daniel@gmail.com>
> 
> 	PR fortran/32467
> 	* gfortran.dg/gomp/allocatable_components_1.f90: New test.

But it would be helpful if you could cover also all the other clauses
in testcases (COPYPRIVATE, FIRSTPRIVATE, LASTPRIVATE and REDUCTION).
Especially because COPYIN resp. COPYPRIVATE are handled in different
code from the other clauses.

	Jakub



More information about the Fortran mailing list