[Fortran, patch] PR32323 - give error for vector subscript actual arguments to intent out/inout

Bernhard Fischer rep.dot.nop@gmail.com
Wed Jun 13 20:02:00 GMT 2007


On Wed, Jun 13, 2007 at 12:56:20PM -0700, Brooks Moses wrote:
>:REVIEWMAIL:
>
>Tobias Burnus wrote:
>>Ok for the trunk?
>
>I have a couple of comments.  Ok once those are addressed.
>
>>(Anyone wants to see this for the branch? I don't.)
>
>It's not a regression or even a wrong-code bug.  So no.  :)
>
>>+/* Given an expression, check whether it is an array section
>>+   which has a vector subscript. If it has, one is returned,
>>+   otherwise zero.  */
>>+
>>+static int
>>+has_vector_section (gfc_expr *e)
>
>I think I'd find this function name a bit clearer as 
>"has_vector_subscript"; there isn't actually such a thing as a "vector 
>section", and so that seems confusing to me.
>
>This is, however, not a strong objection -- feel free to commit this as 
>it stands if you prefer "has_vector_section".

Is there a specific reason not to return a bool in such situations,
generally?



More information about the Fortran mailing list