question on patch submission

[Tobias Burnus]

Christopher D. Rickett schrieb:
> i have a large patch that i've separated into 4 smaller patches for the
> PRs 32600, 32627, 32732, and 32797/32800.  however, both resolve.c and
> trans-expr.c have changes in multiple patches, so the line numbers are a
> little off.  would it be ok to submit the 4 patches separately, or should
> i simply do one large patch?
You can do either:
a) submitting a larger patch which fixes several PRs
b) several smaller patches

(a) has the advantage that the total review time is lower, including
applying and testing
(b) has the advantage that only small changes have to be reviewed and
pinpointing possible regressions is better.

In general, larger patches are ok, but only only if they not get really
large, otherwise they should be broken in parts, if possible. However, I
think all your to-be-submitted patches are relatively small.

You could combine several tiny fixes to a bigger one and send the other
larger patch separately.
In any case, if the changes are not overlapping, "patch" is quite good
to apply unified diffs as FX already pointed out.

Tobias