[Patch, fortran/libgfortran] ABI cleanup for ALLOCATE

[Janne Blomqvist]

Jerry DeLisle wrote:
> Jerry DeLisle wrote:
>> Janne Blomqvist wrote:
>>> :ADDPATCH fortran:
>>>
>>> Hi,
>>>
>>> the attached patch does some ABI cleanup for the parts of libgfortran 
>>> that support the ALLOCATE statement. Currently we have separate 
>>> functions for 32 and 64-bit sizes. However, on 64-bit targets we 
>>> always use the 64-bit variants and on 32-bit targets we always use 
>>> the 32-bit variant. So it's a bit pointless (?) to keep both in the 
>>> library. The patch changes the frontend and library to use the 
>>> correct index_integer_type for sizes (the same type that array 
>>> descriptors use), and removes the 64-bit specific symbols.
>>>
>>> As to why do something like this instead of fixing real bugs, now 
>>> that we have symbol versioning we have until the 4.3 release to do 
>>> whatever ABI fixing we want, after that we are stuck with supporting 
>>> the ABI for a while.
>>>
>>> Regtested on i686-pc-linux-gnu. It would be nice if someone with a 
>>> 64-bit system could test this, and also checking that generating 
>>> 32-bit code using the 64-bit compiler works correctly. After that, Ok 
>>> for trunk?
>>>
>> Janne,
>>
>> I am testing now.  Patch went in clean so no bitrot. :)
>>
>> Jerry
>>
> 
> Regression tested OK on x86-64-Gnu/Linux.
> 
> OK for trunk.
> 
> Jerry

Thanks. Committed to trunk as r126166.



-- 
Janne Blomqvist