[patch, fortran] PR 30381, PR 30420: Fix constant-folding in bitwise intrinsics

Brooks Moses brooks.moses@codesourcery.com
Wed Jan 10 06:40:00 GMT 2007


Steve Kargl wrote:
> OK with a few changes.  In a few places you have error messages of the
> form
> 
> +	gfc_error
> +	  ("Magnitude of second argument of ISHFTC exceeds third argument "
> +	   "at %L", &s->where);
> 
> Please unwrap this to
> 
> 	gfc_error ("Magnitude of second argument of ISHFTC exceeds third
>                "argument at %L", &s->where);
> 
> Try 'grep gfc_error *.c' to see my justification for the request.
> I'm trying to migrate gfortran source code to a uniform style.

Thanks!  Committed, as attached.  I noticed that there are some similar 
error messages in gfc_simplify_ishft() and other nearby places that I 
didn't touch, but I presume your in-progress series of whitespace 
patches will get those?

- Brooks

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bitintrinsics.diff
Type: text/x-patch
Size: 6932 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20070110/fa869e88/attachment.bin>


More information about the Fortran mailing list