[Fortran-Experiments]: patch for error checking on binding labels and derived types, etc.
Tobias Schlüter
tobias.schlueter@physik.uni-muenchen.de
Tue Feb 27 00:53:00 GMT 2007
Hi Chris,
since you will soon have commit privileges, you may want to familiarize
yourself with the ChangeLog format.
Christopher D. Rickett wrote:
> ChangeLog entry:
>
> 2007-02-26 Christopher D. Rickett <crickett@lanl.gov>
> * gcc/testsuite/gfortran.dg/binding_label_tests_10_main.f03: New
> test case to make sure the compiler catches binding label
> collisions across separate files when they're use associated into
> one namespace.
There's no need to spell out the whole path to the testcase. The
ChangeLog entries for testcases goes into gcc/testsuite/ChangeLog, only
a relative path is needed. "New test" suffices as a description, if you
want to be verbose a comment inside the testcase is much more useful.
> * gcc/fortran/decl.c: Updated verify_c_interop_param to include
> procedures. Report an error for BIND(C) derived types that are
> found conclusively to not be C interoperable (warnings still allow
> derived types to be C interoperable). Added checks to
> verify_bind_c_sym to make sure functions do not return arrays or
> strings and if the BIND(C) symbol is PRIVATE, a warning is
> reported if a binding label was given. Updated gfc_match_bind_c
> to allow for NAME="".
The canonical format is:
* affected_file (affected_function): Brief description of change,
if it makes sense describe hunks in the order they appear in the
diff.
(another_function): Again, describe change.
(third_function): Likewise.
* next_file (func): Again a few words.
etc.
This way one is able to easily identify which functions are affected by
the change.
Also please don't gzip patches, unless they're _really_ large, otherwise
the smaller size benefit is easily undone by the extra effort needed to
read the patch.
Cheers, and thanks for your hard work,
- Tobi
More information about the Fortran
mailing list