[Patch, fortran] PR31879 , PR31197 , PR31258 & PR32703 - various character problems

[Paul Richard Thomas]

FX and Tobi,

Many thanks for your respective comments:

(i) The hunk in gfc_conv_function_call is indeed unrelated but is only
a format change;
(ii) I will change the initialization of the loop and assert that the
REF_SUBSTRING is the last in the chain - I actually removed this
assert because it seems to be caught further upstream.  However, it
canot do any harm;
(iii) The e->ts.type is an error - it is missing == BT_CHARACTER &&
!e->ts.cl.  This came about because of bit-rot between the original
writing of the patch and a couple of days ago.  I had to apply quite a
lot of the pacth by hand.  This caused a regression in CP2K that
Tobias Burnus picked up.
(iv) As for PR32156, looked who fixed it.....  Right now, I am not
sure which PR that I meant.

Tobias Burnus and I had an exchange on #gfortran and by email, last
night and this morning.  He identified two problems that have been
fixed but need testcases.  I will emit the updated patch tonight.

Many thanks to you all

Paul