[PATCH] fortran/20869 -- INTRINSIC and EXTERNAL conflict

[Paul Thomas]

Steve,

>
>
>This patch looks better than mine, and think you can commit it.
>You'll need a ChangeLog entry and of course one or more testcases.
>
>
It so happens that I was sensitive to using resolve_symbol for this 
purpose because I had just done so myself, in 
http://gcc.gnu.org/ml/fortran/2006-01/msg00209.html to fix PR25024:

  subroutine A ()    ! { dg-error "cannot be declared EXTERNAL" }
    EXTERNAL A
  END

The enclosed version of the patch fixes this one too; in a much more hygenic fashion.  I will run through the bug database tonight to see if there are any more that it fixes - I am sure that there must be some amongst Joost's PRs.

It regtests OK on Cygwin_NT and FC3.
 
I will commit it, with the requisite testcases and ChangeLog entries, tomorrow evening or Thursday morning, unless there are any objections.  In the mean time, could you please give it a spin with your testsuite?  I am just a little concerned that I might not have exercised all the conditions where procedures are or are not acceptably declared external.  I think that if_source != 0 and contained != 0 cover them all but......

Take it that the modification to resolve.c and the test for PR25024 have been removed from http://gcc.gnu.org/ml/fortran/2006-01/msg00209.html. 

Best regards

Paul


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: attrs.diff
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20060117/a1f93a1b/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: attrs.f90
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20060117/a1f93a1b/attachment.f90>