[PATCH] Fix PR fortran/18157 pointer to user-defined type and assignment

Tobias Schlüter tobias.schlueter@physik.uni-muenchen.de
Tue Oct 25 18:02:00 GMT 2005


Andrew Pinski wrote:
> OK? Bootstrapped and tested on x86_64-pc-linux-gnu with no regressions.
> 
> Also note I created three different testcases.  The first two really should
> not need an temporary array but current uses one (someone else needs to look
> into that).  The last one is the only one which really needs one.

Well, strictly speaking the third testcase doesn't need a temporary either, as
the loop can be reversed.

I have two comments:

> ChangeLog:
> 	* trans-array.c (gfc_conv_resolve_dependencies): Use the correct
> 	type of the temparory array.
                    ^^^^^^^^^
s/temparory/temporary/ here and everywhere else.

> 	* trans-expr.c (gfc_trans_assignment): Pass lss instead of lss_section
> 	to gfc_conv_resolve_dependencies to get the correct type.

You need the same change in gfc_trans_where_assign as well (+ a corresponding
testcase).

Otherwise this is ok.

Thanks,
- Tobi



More information about the Fortran mailing list