[PATCH, libgfortran] PR24794 namelist input of character array

Jerry DeLisle jvdelisle@verizon.net
Mon Nov 21 05:55:00 GMT 2005


> 
> After some more testing and study I have a further minor change to this 
> patch that I will be submitting a bit later.  This will allow ' ' 
> separated objects. After I 'discovered' this I encountered four 
> regressions.  Three of the four failed because they did not comply with 
> the standard requirement that character strings must be quote delimited 
> in a namelist input file.  The fourth and last case involves derived 
> types, aka 'tricky'.
> 
> I will report back when I figure it out.
> 
:REVIEWPATCH fortran:
Hopefully this is the final cycle.  The attached patch is trivial.  I 
kept going around the wrong corners because the test cases were all a 
bit inconsistent until I figured it out.

I have attached the final patch and included each of the test cases 
that changed.  The only changes in the test cases are the use of 
delim="apostrophe" on the open statements and single quoting the 
pertinent strings when creating the nml input scratch files for the tests.

Regression testing completed and passed.

OK for Trunk?  OK for 4.0-branch?

Regards,

Jerry


-------------- next part --------------
A non-text attachment was scrubbed...
Name: list_read2.diff
Type: text/x-patch
Size: 373 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20051121/fc98f874/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: namelist_12.f
Type: text/x-fortran
Size: 1645 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20051121/fc98f874/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: namelist_13.f90
Type: application/x-extension-f90
Size: 1030 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20051121/fc98f874/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: namelist_14.f90
Type: application/x-extension-f90
Size: 3163 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20051121/fc98f874/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: namelist_15.f90
Type: application/x-extension-f90
Size: 1873 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20051121/fc98f874/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: namelist_21.f90
Type: application/x-extension-f90
Size: 1251 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20051121/fc98f874/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: namelist_22.f90
Type: application/x-extension-f90
Size: 1335 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20051121/fc98f874/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: namelist_use.f90
Type: application/x-extension-f90
Size: 944 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20051121/fc98f874/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: namelist_use_only.f90
Type: application/x-extension-f90
Size: 1215 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/fortran/attachments/20051121/fc98f874/attachment-0008.bin>


More information about the Fortran mailing list