[Patch, fortran] PR24409 - ICE on module name vs dummy argument name

[Paul Thomas]

Steve,

>If tested this on i386-*-freebsd and I've seen your email
>addressing Tobi's question.  I think the patch is ok.  Note,
>your ChangeLog entry should reflect the date when the patch
>is committed.
>  
>
Yes, indeed. Leaving them as they were was a half hearted apology for 
forgetting the patch.

>PS: Someday, we should document the gfortran and libgfortran
>    internals on the wiki.  AFAIK, Paul T is the only person
>    with a grasp on how modules work. :(
>  
>
I think that you are right. Maybe I should write something on module.c, 
whilst I still have a grasp on it! It is a very slippery thing.

It is my belief that module.c is more complicated, at the front end, 
that it needs to be. Also, for complicated codes, it can be very slow 
because it reads the .mod file and reconstructs the contribution to the 
symtree each time a module is used. As a medium-ish term project, I 
intend to make a list of module namespaces, into which the .mod files 
are unconditionally read... once. The use should then be made from those 
namespaces. The interior is very clever and merits some investigation.

Paul