[Patch, fortran] PR24174 real(10) and complex(10) array IO broken.

Tobias Schlüter tobias.schlueter@physik.uni-muenchen.de
Sun Nov 6 19:00:00 GMT 2005


Janne Blomqvist wrote:
> I have committed the patch with the changes in wording proposed by
> Brooks Moses (thanks!). I also changed the testcase to test for
> 
> (abs(a-b) > 10 * spacing (2.0_k))
> 
> instead of testing for exact equality, since we're after all talking
> about converting FP numbers to strings and back. For some reason doing
> an exact test works for me, but I'm not so sure it will always work.

If the number can be expressed exactly in decimal, testing for equality is the
right thing.  If the user writes "1.0" he expects this to be read back as 1.0.

> And, since this is my first ever a) gcc commit and b) svn commit, I
> hope I haven't made any major screwups...

Congratulations on your newly obtained powers!  You should add yourself to the
"Write after approval" section of MAINTAINERS.

- Tobi




More information about the Fortran mailing list