[gfortran] patch PR 20788
Tobias Schlüter
tobias.schlueter@physik.uni-muenchen.de
Mon May 9 18:43:00 GMT 2005
François-Xavier Coudert wrote:
> Regtested on i386-linux. OK for mainline and 4.0?
>
>
> ------------------------------------------------------------------------
>
> 2005-05-02 Francois-Xavier Coudert <coudert@clipper.ens.fr>
>
> PR libfortran/20788
> * io/unix.c (fd_to_stream): Add an avoid_mmap argument indicating
> we don't we to mmap this stream. Use fd_open instead of mmap_open
> in that case.
> (open_external): Call fd_to_stream with avoid_mmap = 0.
> (input_stream): Call fd_to_stream with avoid_mmap = 1.
> (output_stream): Likewise.
> (error_stream): Likewise.
>
Steve's "whoops" mail reminded me that I hadn't yet answered to this mail.
I think it's pointless to add avoid_mmap to fd_to_stream's interface, and
would prefer if you explicitly checked for the affected three units in that
function. Or is it likely that there will be other cases where this is necessary?
The patch is of course correct, and you can leave it installed if you don't
agree with me.
- Tobi
More information about the Fortran
mailing list