[PATCH] Fix for PR fortran/21375

Steve Kargl sgk@troutmask.apl.washington.edu
Mon Jun 6 22:03:00 GMT 2005


On Sun, Jun 05, 2005 at 12:03:59PM -0700, Steve Kargl wrote:
> On Sun, Jun 05, 2005 at 06:46:12PM +0100, Paul Brook wrote:
> > > See attached patch (for a fun exercise in hacking).
> > > Bootstrapped and regression tested on i386-*-freebsd.
> > > ChangeLog entries for patch and test case are the
> > > same as in the first email of the thread.
> > 
> > >+       apstat = gfc_build_addr_expr (NULL, astat);
> > >+       apstat = build_int_cst (gfc_int4_type_node, 0);
> > 
> > This looks wrong. Assigning to a variable then immediately overwriting its 
> > value.
> > 
> > Presumably there should be some library changes to go with this patch?
> > It's also missing a ChangeLog entry.
> > 
> > It would also be nice to have a comment that explained (in C or pseudocode) 
> > what we the code we generate should look like.
> > 
> 
> See patch.


This patch has now been tested on i386-*-freebsd and amd64-*-freebsd.
There are no new regression caused by this patch.

-- 
steve



More information about the Fortran mailing list