[Patch/gfortran] PR18283

[Paul Thomas]

Tobi,

 > ! tmp = fold_build2 (MINUS_EXPR, gfc_charlen_type_node, len,
 > ! convert (gfc_charlen_type_node, integer_one_node));

build_int_cst (gfc_charlen_type_node, 1)

 > ! tmp = build_range_type (gfc_array_index_type, gfc_index_zero_node,

The convert is indeed all over the place in that file; in fact I cut and 
paste it from a few lines away What is your reason for preferring to 
replace it with build_int_cst (type, value)?  On the face of it, I would 
have thought that the convert is better.

Paul T