[PATCH,gfortran] Remove homegrown isdigit and isalpha in module.c

Tobias Schlüter tobias.schlueter@physik.uni-muenchen.de
Sun Jan 9 21:30:00 GMT 2005


Steve Kargl wrote:
> -
> -    case 'a':
> -    case 'b':
> -    case 'c':
...
> -    case 'Y':
> -    case 'Z':
> +    }
> +  else if (isalpha(c))

isalpha is locale-dependent, in my locale you will allow äöüÄÖÜß as well.
Modules are of course compiler-generated, but it would be safer and not much
more complicated to say
   else if ('a' <= c <= 'z' || 'A' <= c <= 'Z')
instead.

I also think that inside gcc ISDIGIT (which comes from libiberty) is the
preferred spelling for isdigit.

- Tobi



More information about the Fortran mailing list