[RFC][PATCH] -d_lines
Tobias Schlüter
tobias.schlueter@physik.uni-muenchen.de
Wed Aug 17 20:30:00 GMT 2005
Andrew Pinski wrote:
> On Aug 17, 2005, at 3:54 PM, Tobias Schlüter wrote:
>
>
>>+ /* Find end of file name. */
>>+ i = 0;
>>+ while ((i < PATH_MAX) && (filename[i] != '\0'))
>>+ i++;
>>+
>>+ /* Improperly terminated or too-long filename. */
>>+ if (i == PATH_MAX)
>>+ return FORM_UNKNOWN;
>
>
> You are introducing a depend on PATH_MAX which is not correct.
> If the filename is not ending in 0, well let the compiler crash
> because there is something wrong inside the compiler.
>
> All uses of PATH_MAX should be removed from the fortran front-end.
> I thought there was a patch to do just that.
Yes, but it looks like it wasn't committed before I copy'n'pasted that chunk.
Thanks for spotting this. I'll combine this with Steve's patch from
http://gcc.gnu.org/ml/fortran/2005-08/msg00009.html, which I had approved before.
Ok?
- Tobi
More information about the Fortran
mailing list