[gfortran] Minor cleanup to trans-intrinsic.c

Tobias Schlüter tobias.schlueter@physik.uni-muenchen.de
Mon Dec 20 19:02:00 GMT 2004


Tobias Schlüter wrote:
> 2004-12-20  Tobias Schlueter  <tobias.schlueter@physik.uni-muenchen.de>
> 
> 	* trans-intrinsic.c (build_fix_expr): Change 'op' argument
> 	to correct enum type.
> 	(gfc_conv_intrinsic_aint): Likewise.  Also correct comment in
> 	front of function.  Add default case to switch.
Sigh.

This hunk leads to testsuite failures:
> @@ -350,6 +353,10 @@ gfc_conv_intrinsic_aint (gfc_se * se, gf
>           n = BUILT_IN_FLOOR;
>           break;
>         }
> +      break;
> +
> +    default:
> +      gcc_unreachable ();
>      }
> 
>    /* Evaluate the argument.  */

Because the switch deals with FIX_ROUND_EXPR and FIX_FLOOR_EXPR, but the
function is called with FIX_ROUND_EXPR and FIX_TRUNC_EXPR, which I had
originally misread.

Would this patch be ok if I added
   case FIX_TRUNC_EXPR:
      break;
to the switch?

Sorry,
- Tobi




More information about the Fortran mailing list