[PATCH V4] New version of proc whole and dependencies
Jose E. Marchesi
jemarch@gnu.org
Sun Jul 19 20:59:23 GMT 2026
> Good morning everyone,
>
> Jose, I'm struggling with the git gcc-verify results and I'm hoping
> you can help...
>
> On Sun, Jul 19, 2026 at 1:40 AM Jose E. Marchesi <jemarch@gnu.org> wrote:
>>
>>
>> Hello Chris.
>>
>> The patch itself looks good, thank you.
>>
>> Please send a V5 to gcc-patches@gcc.gnu.org CCing algol68@gcc.gnu.org,
>> with the following changes, for approval:
>>
>> 1) Add to the commit message a tag:
>>
>> Signed-off-by: Chris Hermansen <clhermansen@gmail.com>
>>
>> On its own line. This signifies you are contributing the code to GCC
>> under the DCO. The alternative is to assign the copyright to the
>> FSF, which requires a little extra procedure.
>>
>> 2) Add changelog entries to the commit message. This time I did it for
>> you, just add the following:
>>
>> gcc/algol68/ChangeLog
>>
>> * standard.a68.in (Integer): New mode.
>> (whole_max_entry): New variable.
>> (whole_p10): Likewise.
>> (whole_stop_after): Likewise.
>> (whole_powers_of_10): Likewise.
>> (WHOLEDIGITS): New operator.
>> (whole): Rewrite.
>> (subwhole): Likewise.
>>
>> gcc/testsuite/ChangeLog
>>
>> * algol68/execute/whole-1.a68: New test.
>>
>> Note that the tabs are important.
>>
>> Make sure to execute
>>
>> $ git gcc-verify
>>
>> before sending the patch to gcc-patches@, to make sure everything is in
>> order.
>>
>> Thanks!
>>
> [stuff deleted]
>
> I have rebased the changes back on master, squashed the commits together
> and done a commit --amend to prepare the commit message including what you
> mention above with regard to signed off and change log. Here are the relevant
> lines added to the change log:
>
> Signed-off-by: Chris Hermansen <clhermansen@gmail.com>
>
> gcc/algol68/ChangeLog
>
> * standard.a68.in (Integer): New mode.
> (whole_max_entry): New variable.
> (whole_p10): Likewise.
> (whole_stop_after): Likewise.
> (whole_powers_of_10): Likewise.
> (WHOLEDIGITS): New operator.
> (whole): Rewrite.
> (subwhole): Likewise.
>
> gcc/testsuite/ChangeLog
>
> * algol68/execute/whole-1.a68: New test.
>
> Per your "note that the tabs are important", I have replaced 8 spaces
> in front of the
> indented lines above with a tab; perhaps I mis-interpreted?
>
> In any event, git gcc-verify produces the following output:
>
> Checking 617c1e3d42ce38bc05b52bab0b4a7ae33b18505a: FAILED
> ERR: unchanged file mentioned in a ChangeLog (did you mean
> "libga68/standard.a68.in"?): "gcc/algol68/standard.a68.in"
> ERR: changed file not mentioned in a ChangeLog: "libga68/standard.a68.in"
>
> It seems that gcc-verify is extracting the "gcc/algol68/" from the
> ChangeLog line
> above and prepending it to "standard.a68.in". I've tried a few
> different things on
> the "* standard.a68.in" line, such as "libga68/standard.a68.in", which produces:
>
> Checking fb31e19329df454df886124826a8fdd2ea2be066: FAILED
> ERR: unchanged file mentioned in a ChangeLog (did you mean
> "libga68/standard.a68.in"?): "gcc/algol68/libga68/standard.a68.in"
> ERR: changed file not mentioned in a ChangeLog: "libga68/standard.a68.in"
>
> and even "* ../../libga68/standard.a68.in" which produces
>
> Checking 28b8d8bc328440c457b7ffd35737c2f018239aa9: FAILED
> ERR: unchanged file mentioned in a ChangeLog (did you mean
> "libga68/standard.a68.in"?):
> "gcc/algol68/../../libga68/standard.a68.in"
> ERR: changed file not mentioned in a ChangeLog: "libga68/standard.a68.in"
>
> though "ls -l gcc/algol68/../../libga68/standard.a68.in" produces
> -rw-rw-r-- 1 clh clh 16103 Jul 19 09:46
> gcc/algol68/../../libga68/standard.a68.in
>
> I'm sure I'm going down the wrong rabbit hole here... any suggestions?
>
> Thanks in advance!
Oh, this was my fault. The directory with the ChangeLog to use for
standard.a68.in is gcc/libga68. Try with:
libga68/ChangeLog
<TAB>* standard.a68.in (Integer): New mode.
<TAB>(whole_max_entry): New variable.
<TAB>(whole_p10): Likewise.
<TAB>(whole_stop_after): Likewise.
<TAB>(whole_powers_of_10): Likewise.
<TAB>(WHOLEDIGITS): New operator.
<TAB>(whole): Rewrite.
<TAB>(subwhole): Likewise.
gcc/testsuite/ChangeLog
<TAB>* algol68/execute/whole-1.a68: New test.
More information about the Algol68
mailing list