[PATCH] algol68: libga68: Fix typo and code style

Jose E. Marchesi jemarch@gnu.org
Tue Apr 29 06:03:02 GMT 2025


Hi Pietro.

If you can file a PR for the particular approved change (I suppose you
have it in a branch) then I will merge it.

> On Sun, Apr 27, 2025, at 4:06 AM, Jose E. Marchesi wrote:
>> Hello Pietro.
>>
>> OK for gcc-a68/a68.
>
> I think you need to grant my forge user "pietro" write access to the gcc-a68 project:
>
> remote: Forgejo: User permission denied for writing.
> To forge.sourceware.org:gcc/gcc-a68.git
>  ! [remote rejected]         a68 -> a68 (pre-receive hook declined)
> error: failed to push some refs to 'forge.sourceware.org:gcc/gcc-a68.git'
>
>> Gracias!
>
> De nada!
>
> pietro.
>
>>> libga68/ChangeLog:
>>>
>>> 	* ga68-error.c (_libga68_lower_bound): Place function name in
>>> 	column one of new line.
>>> 	(_libga68_upper_bound): Likewise.
>>> 	* ga68-posix.c (_libga68_posixgets): Likewise.
>>> 	* ga68.h (_libga68_posixperror): Fix typo.
>>>
>>> Signed-off-by: Pietro Monteiro <pietro@sociotechnical.xyz>
>>> ---
>>>  libga68/ga68-error.c | 6 ++++--
>>>  libga68/ga68-posix.c | 4 ++--
>>>  libga68/ga68.h       | 2 +-
>>>  3 files changed, 7 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/libga68/ga68-error.c b/libga68/ga68-error.c
>>> index 6c2891700d7..84ae12eb7bd 100644
>>> --- a/libga68/ga68-error.c
>>> +++ b/libga68/ga68-error.c
>>> @@ -100,7 +100,8 @@ _libga68_unreachable (const char *filename, unsigned int lineno)
>>>  
>>>  /* Lower bound failure.  */
>>>  
>>> -void _libga68_lower_bound (const char *filename, unsigned int lineno,
>>> +void
>>> +_libga68_lower_bound (const char *filename, unsigned int lineno,
>>>  			   ssize_t index, ssize_t lower_bound)
>>>  {
>>>    _libga68_abort ("%s:%d: runtime error: lower bound %d must be >= %d\n",
>>> @@ -109,7 +110,8 @@ void _libga68_lower_bound (const char *filename, unsigned int lineno,
>>>  
>>>  /* Upper bound failure.  */
>>>  
>>> -void _libga68_upper_bound (const char *filename, unsigned int lineno,
>>> +void
>>> +_libga68_upper_bound (const char *filename, unsigned int lineno,
>>>  			   ssize_t index, ssize_t upper_bound)
>>>  {
>>>    _libga68_abort ("%s:%d: runtime error: upper bound %d must be <= %d\n",
>>> diff --git a/libga68/ga68-posix.c b/libga68/ga68-posix.c
>>> index 4a6c564542d..24eb90623d2 100644
>>> --- a/libga68/ga68-posix.c
>>> +++ b/libga68/ga68-posix.c
>>> @@ -324,8 +324,8 @@ _libga68_posixfgets (int fd, int nchars, size_t *len)
>>>  
>>>  /* Implementation of the posix prelude `posix gets'.  */
>>>  
>>> -uint32_t
>>> -*_libga68_posixgets (int nchars, size_t *len)
>>> +uint32_t *
>>> +_libga68_posixgets (int nchars, size_t *len)
>>>  {
>>>    return _libga68_posixfgets (0, nchars, len);
>>>  }
>>> diff --git a/libga68/ga68.h b/libga68/ga68.h
>>> index 0dc27ddfb25..12195efa8d9 100644
>>> --- a/libga68/ga68.h
>>> +++ b/libga68/ga68.h
>>> @@ -71,7 +71,7 @@ long double _libga68_longlongrandom (void);
>>>  /* ga68-posix.c  */
>>>  
>>>  int _libga68_posixerrno (void);
>>> -void _liga68_posixperror (uint32_t *s, size_t len, size_t stride);
>>> +void _libga68_posixperror (uint32_t *s, size_t len, size_t stride);
>>>  uint32_t *_libga68_posixstrerror (int errnum, size_t *len);
>>>  long long int _libga68_posixfsize (int fd);
>>>  int _libga68_posixfopen (uint32_t *pathname, size_t len, size_t stride, unsigned int flags);


More information about the Algol68 mailing list