This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
[PATCH, testsuite] Skip new charset tests on Darwin8-10.
- From: Iain Sandoe <iain at sandoe dot co dot uk>
- To: libstdc++ <libstdc++ at gcc dot gnu dot org>, GCC-patches <gcc-patches at gcc dot gnu dot org>
- Cc: Jonathan Wakely <jwakely at redhat dot com>
- Date: Sat, 12 Jan 2019 16:46:34 +0000
- Subject: [PATCH, testsuite] Skip new charset tests on Darwin8-10.
Hi,
These earlier Darwin versions have “FP_≈” inside a comment in architecture/{ppc,i386}/math.h, which is included by math.h which causes the tests to fail.
The intent of the tests (i.e. to ensure that the library itself does not emit non-ascii) is covered by other platforms, including later Darwin editions. AFAICT, this issue was fixed from Darwin11 onwards (although I have not tested every edition / looked for other possible non-ascii cases, in other headers).
Since there’s no expectation that the headers would ever be updated, and it doesn’t seem worth applying fixincludes for this, let’s skip the tests on versions with the issue.
Tested on powerpc-darwin9, x86_64-darwin10 and x86_64-darwin18.
OK for trunk?
Iain
libstdc++v3/testsuite/
* 17_intro/headers/c++1998/charset.cc: Skip for Darwin8 to Darwin10.
* 17_intro/headers/c++2011/charset.cc: Likewise.
* 17_intro/headers/c++2014/charset.cc: Likewise.
* 17_intro/headers/c++2017/charset.cc: Likewise.
* 17_intro/headers/c++2020/charset.cc: Likewise.
diff --git a/libstdc++-v3/testsuite/17_intro/headers/c++1998/charset.cc b/libstdc++-v3/testsuite/17_intro/headers/c++1998/charset.cc
index 864c64e..4425e1c 100644
--- a/libstdc++-v3/testsuite/17_intro/headers/c++1998/charset.cc
+++ b/libstdc++-v3/testsuite/17_intro/headers/c++1998/charset.cc
@@ -1,4 +1,5 @@
// { dg-options "-finput-charset=ascii" }
// { dg-do compile }
+// { dg-skip-if "non-ascii in system headers" { *-*-darwin10* *-*-darwin[89]* } }
#include <bits/extc++.h>
diff --git a/libstdc++-v3/testsuite/17_intro/headers/c++2011/charset.cc b/libstdc++-v3/testsuite/17_intro/headers/c++2011/charset.cc
index 864c64e..4425e1c 100644
--- a/libstdc++-v3/testsuite/17_intro/headers/c++2011/charset.cc
+++ b/libstdc++-v3/testsuite/17_intro/headers/c++2011/charset.cc
@@ -1,4 +1,5 @@
// { dg-options "-finput-charset=ascii" }
// { dg-do compile }
+// { dg-skip-if "non-ascii in system headers" { *-*-darwin10* *-*-darwin[89]* } }
#include <bits/extc++.h>
diff --git a/libstdc++-v3/testsuite/17_intro/headers/c++2014/charset.cc b/libstdc++-v3/testsuite/17_intro/headers/c++2014/charset.cc
index 864c64e..4425e1c 100644
--- a/libstdc++-v3/testsuite/17_intro/headers/c++2014/charset.cc
+++ b/libstdc++-v3/testsuite/17_intro/headers/c++2014/charset.cc
@@ -1,4 +1,5 @@
// { dg-options "-finput-charset=ascii" }
// { dg-do compile }
+// { dg-skip-if "non-ascii in system headers" { *-*-darwin10* *-*-darwin[89]* } }
#include <bits/extc++.h>
diff --git a/libstdc++-v3/testsuite/17_intro/headers/c++2017/charset.cc b/libstdc++-v3/testsuite/17_intro/headers/c++2017/charset.cc
index 864c64e..4425e1c 100644
--- a/libstdc++-v3/testsuite/17_intro/headers/c++2017/charset.cc
+++ b/libstdc++-v3/testsuite/17_intro/headers/c++2017/charset.cc
@@ -1,4 +1,5 @@
// { dg-options "-finput-charset=ascii" }
// { dg-do compile }
+// { dg-skip-if "non-ascii in system headers" { *-*-darwin10* *-*-darwin[89]* } }
#include <bits/extc++.h>
diff --git a/libstdc++-v3/testsuite/17_intro/headers/c++2020/charset.cc b/libstdc++-v3/testsuite/17_intro/headers/c++2020/charset.cc
index 864c64e..4425e1c 100644
--- a/libstdc++-v3/testsuite/17_intro/headers/c++2020/charset.cc
+++ b/libstdc++-v3/testsuite/17_intro/headers/c++2020/charset.cc
@@ -1,4 +1,5 @@
// { dg-options "-finput-charset=ascii" }
// { dg-do compile }
+// { dg-skip-if "non-ascii in system headers" { *-*-darwin10* *-*-darwin[89]* } }
#include <bits/extc++.h>