This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Add missing noexpect causes in tuple for move functions
- From: nick <xerofoify at gmail dot com>
- To: Ville Voutilainen <ville dot voutilainen at gmail dot com>
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>, libstdc++ <libstdc++ at gcc dot gnu dot org>
- Date: Fri, 30 Nov 2018 20:03:37 -0500
- Subject: Re: [PATCH] Add missing noexpect causes in tuple for move functions
- References: <20181130230529.1499-1-xerofoify@gmail.com> <CAFk2RUZRRWCxn1w1+v0NUDAYnp-vsMhw=28ThpQ2KmdNmkQ-6w@mail.gmail.com>
On 2018-11-30 6:12 p.m., Ville Voutilainen wrote:
> On Sat, 1 Dec 2018 at 01:05, Nicholas Krause <xerofoify@gmail.com> wrote:
>>
>> This adds the remainging noexcept causes required for this cause
>> to meet the spec as dicussed last year and documented here:
>> http://cplusplus.github.io/LWG/lwg-active.html#2899.
>
> I don't see how this change is sufficient; the noexcept-specs need to
> be added to tuple's
> special member functions, not just to _Tuple_impl, and your suggested
> patch contains no
> tests.
>
It was tested I just didn't mention that as it was assumed, that's my mistake and
sorry for that. This was more just to make sure that this is fine. If you would
prefer I send a patch cleaning it up for all the classes i.e. tuple, and it's
version's that's fine. I just want to ask do you want a patch or a series will
each patch touching one of the tuple clases as I assume your the maintainer.
Cheers,
Nick