This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use __builtin_memmove for trivially copy assignable types


On 19/07/18 10:32 -0400, Glen Fernandes wrote:
On Thu, Jul 19, 2018 at 10:01 AM Glen Fernandes wrote:

I was still unclear about that, but I forwarded you an e-mail from
Marshall with his answer when I asked whether libc++'s use of
TriviallyCopyAssignable here was incorrect. Let me know if it applies
here, and if not (and that interpretation of the standard is
incorrect), I'll update the patch to do as you suggest and run the
tests again.

Glen

Attached: patch.txt

Use __builtin_memmove for trivially copyable types

2018-07-19  Glen Joseph Fernandes  <glenjofe@gmail.com>

   * include/bits/stl_algobase.h
   (__copy_move_a): Used __is_trivially_copyable.
   (__copy_move_backward_a): Likewise.

Tested x86_64-pc-linux-gnu.

Ah, that was quick :-)

Can we keep the new test you added in the previous patch? It seems
useful to add anyway.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]