This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR libstdc++/80506 fix constant used in condition

From: Jonathan Wakely <jwakely at redhat dot com>
To: Ed Smith-Rowland <3dw4rd at verizon dot net>
Cc: Paolo Carlini <paolo dot carlini at oracle dot com>, libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org, Vincent Poinot <poinot dot v at gmail dot com>
Date: Mon, 7 May 2018 13:22:53 +0100
Subject: Re: [PATCH] PR libstdc++/80506 fix constant used in condition
References: <20170424134316.GA16538@redhat.com> <5a44e474-356e-dbab-a1a4-548d4e049441@oracle.com> <9edaa145-40e6-6e71-cc6f-afa643281e67@oracle.com> <20170426091601.GI5109@redhat.com> <81517154-e7a8-652e-eb65-3221b674a50b@verizon.net>

On 05/05/18 21:19 -0400, Ed Smith-Rowland wrote:

On 04/26/2017 05:16 AM, Jonathan Wakely wrote:

On 26/04/17 11:14 +0200, Paolo Carlini wrote:

.. or maybe using the wrong constant only impacts the performance?!?


Yes, I think so. I did some very simple sanity tests and the numbers
were identical before and after.

I was backporting this and saw that __generate_impl does this twice more.

For trunk and branch-8 I have these patches.

OK?


OK, thanks for noticing the additional cases.

References:
- Re: [PATCH] PR libstdc++/80506 fix constant used in condition
  - From: Ed Smith-Rowland

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]