This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [libstdc++][testsuite] Fix dg-options/dg-add-options order
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Christophe Lyon <christophe dot lyon at linaro dot org>
- Cc: gcc Patches <gcc-patches at gcc dot gnu dot org>, libstdc++ at gcc dot gnu dot org
- Date: Fri, 19 Jan 2018 10:12:30 +0000
- Subject: Re: [libstdc++][testsuite] Fix dg-options/dg-add-options order
- Authentication-results: sourceware.org; auth=none
- References: <CAKdteOYGYZUoQHd2b9+bjRLP4W8T9NFapbXUHjtnJT2LaTg0_Q@mail.gmail.com>
On 19/01/18 09:44 +0100, Christophe Lyon wrote:
Hi,
While checking dg directives order, I've noticed a few libstdc++ tests
where the current order is:
// { dg-add-options ieee }
// { dg-options "-D__STDCPP_WANT_MATH_SPEC_FUNCS__" }
while dg-add-options should be after dg-options.
Yes, those are wrong. I have a script to check for this but have
forgotten to run it recently:
./testsuite/ext/special_functions/airy_ai/check_nan.cc has dg-options after dg-add-options
./testsuite/ext/special_functions/hyperg/check_nan.cc has dg-options after dg-add-options
./testsuite/ext/special_functions/conf_hyperg/check_nan.cc has dg-options after dg-add-options
./testsuite/ext/special_functions/airy_bi/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/02_assoc_legendre/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/14_expint/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/12_ellint_2/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/09_cyl_bessel_k/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/21_sph_neumann/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/15_hermite/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/19_sph_bessel/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/05_comp_ellint_2/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/11_ellint_1/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/17_legendre/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/10_cyl_neumann/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/06_comp_ellint_3/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/06_comp_ellint_3/pr66689.cc has dg-options after dg-add-options
./testsuite/special_functions/01_assoc_laguerre/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/16_laguerre/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/13_ellint_3/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/13_ellint_3/pr66689.cc has dg-options after dg-add-options
./testsuite/special_functions/07_cyl_bessel_i/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/18_riemann_zeta/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/08_cyl_bessel_j/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/04_comp_ellint_1/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/03_beta/check_nan.cc has dg-options after dg-add-options
./testsuite/special_functions/20_sph_legendre/check_nan.cc has dg-options after dg-add-options
The attached patch fixes that, is that OK for stage4?
Yes, testsuite changes are OK. Thanks!