This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Smart pointer pretty printers


On 09/01/18 18:50 +0000, Jonathan Wakely wrote:
On 09/01/18 15:02 +0000, Jonathan Wakely wrote:
On 09/01/18 14:59 +0000, Jonathan Wakely wrote:
On 04/01/18 11:22 +0100, Juraj Oršulić wrote:
Hi Jonathan (and the libstdc++ list). Can we revive this? I sent the
patches for improving the smart pointer pretty printers in March. They
haven't been reviewed.

Thanks for the reminder. I'm testing the attached patch, which has
been rebased on trunk, but I'm getting test failures for the
shared_ptr printers.

I can't see any difference between the expected output and what GDB
prints, so I think it's some DejaGnu or Tcl/Tk oddity. The actual
printer seems to work OK.

No, the problem is that I'm just misreading the results.

I'll finish testing and commit this soon.

I changed the code slightly, so it still works for GDB versions older
than 7.5, which don't have the fix to allow children() to return a
list. There's no easy way to tell if the GDB interpreting the code has
the fix or not.

Thanks very much for the patches, and sorry for the delay reviewing
them.

Tested x86_64-linux, committed to trunk.

I've just realised I didn't put your name in the ChangeLog, sorry!
(I semi-automate my changelog entries, so have to remember to do an
extra step when I'm not the author, or not the sole author).

Fixed with this patch, committed to trunk.



commit b4e59f03b68387c5b556f3d8430ece8927cdca9f
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Jan 9 22:01:20 2018 +0000

    Correct earlier ChangeLog entry
    
    Add Juraj Oršulić as original patch author.

diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog
index 6c5a2741ba8..88af8ecf37c 100644
--- a/libstdc++-v3/ChangeLog
+++ b/libstdc++-v3/ChangeLog
@@ -32,7 +32,8 @@
 	* testsuite/23_containers/unordered_map/insert/83709.cc: New.
 	* testsuite/23_containers/unordered_set/insert/83709.cc: New.
 
-2018-01-09  Jonathan Wakely  <jwakely@redhat.com>
+2018-01-09  Juraj Oršulić  <juraj.orsulic@fer.hr>
+	    Jonathan Wakely  <jwakely@redhat.com>
 
 	PR libstdc++/59253 (partial)
 	* python/libstdcxx/v6/printers.py (SmartPtrIterator): Common iterator

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]