This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: std::advance istreambuf_iterator overload


On 20/11/17 07:40 +0100, François Dumont wrote:
Here is the latest version I plan to commit after validation.

I like the simplified logic for the while-loop.

I'd like to keep the change to the money_get/get/[char/wchar_t]/9.cc tests. At the moment those tests passes only because there is no operation on the is iterator (like a check for eof). If we add any, internal _M_buf will be reseted and tests will start to fail.

Those changes seem useful then, thanks.

Tested under Linux x86_64 normal and debug modes.

Ok to commit ?

OK for trunk, thanks!



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]