This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [testsuite, i386] Always check for target i?86 and x86_64
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org, fortran at gcc dot gnu dot org, Uros Bizjak <ubizjak at gmail dot com>, Jonathan Yong <10walls at gmail dot com>, Mike Stump <mikestump at comcast dot net>
- Date: Thu, 15 Jun 2017 12:31:04 +0100
- Subject: Re: [testsuite, i386] Always check for target i?86 and x86_64
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jwakely at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com EBD79128D
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EBD79128D
- References: <yddo9tp5xs7.fsf@CeBiTec.Uni-Bielefeld.DE>
On 15/06/17 12:51 +0200, Rainer Orth wrote:
I happened to notice that recently a couple of testcases have sneaked in
that are restricted to x86_64-*-* targets only. This is always wrong:
it should be i?86-*-* and x86_64-*-* alike, eventually restricing the
test to ilp32 or lp64. There were also instances of i?86-*-* only,
which I've handled as well.
[...]
diff --git a/libstdc++-v3/testsuite/20_util/variant/index_type.cc b/libstdc++-v3/testsuite/20_util/variant/index_type.cc
--- a/libstdc++-v3/testsuite/20_util/variant/index_type.cc
+++ b/libstdc++-v3/testsuite/20_util/variant/index_type.cc
@@ -1,5 +1,5 @@
// { dg-options "-std=gnu++17" }
-// { dg-do compile { target x86_64-*-* powerpc*-*-* } }
+// { dg-do compile { target i?86-*-* x86_64-*-* powerpc*-*-* } }
// Copyright (C) 2017 Free Software Foundation, Inc.
//
The concern here was just that we don't want the test to fail on
targets with weird integer sizes, so the list of targets was
restricted to just those where Ville had tested it.
But { target ilp32 lp64 } would surely be fine. The test will only
fail if a struct with two char-sized subobjects is the same size as
size_t. Feel free to change it to { target ilp32 lp64 }.