This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Implement non-trivial std::random_device::entropy (PR libstdc++/67578)
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Xi Ruoyao <ryxi at stu dot xidian dot edu dot cn>
- Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Mon, 22 May 2017 14:50:02 +0100
- Subject: Re: [PATCH] Implement non-trivial std::random_device::entropy (PR libstdc++/67578)
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jwakely at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A4A3C81127
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A4A3C81127
- References: <1495106850.1663.8.camel@stu.xidian.edu.cn> <20170522130058.GF4527@redhat.com> <1495460501.29130.6.camel@stu.xidian.edu.cn>
On 22/05/17 21:41 +0800, Xi Ruoyao wrote:
On 2017-05-22 14:00 +0100, Jonathan Wakely wrote:
On 18/05/17 19:27 +0800, Xi Ruoyao wrote:
> This patch use ioctl to get entropy of std::random_device using
> /dev/random and /dev/urandom.
This is a nice addition, thanks.
N.B. I couldn't apply your patch, several lines had U+00A0 (i.e.
NO-BREAK SPACE) characters where normal spaces should be. I don't know
if this is something your mail client did, but maybe attaching the
patch as a multipart message rather than including it inline in the
body will prevent it in future.
Oh no... Seems my email client destroyed my patch. I'll attach the
patch next time. Please wait for PATCH v2.
OK, will do. I missed part of the required changes when adding a new
symbol version, see the attached patch.
diff --git a/libstdc++-v3/testsuite/util/testsuite_abi.cc b/libstdc++-v3/testsuite/util/testsuite_abi.cc
index 953c907..ee7572e 100644
--- a/libstdc++-v3/testsuite/util/testsuite_abi.cc
+++ b/libstdc++-v3/testsuite/util/testsuite_abi.cc
@@ -235,7 +235,7 @@ check_version(symbol& test, bool added)
test.version_status = symbol::incompatible;
// Check that added symbols are added in the latest pre-release version.
- bool latestp = (test.version_name == "GLIBCXX_3.4.23"
+ bool latestp = (test.version_name == "GLIBCXX_3.4.24"
|| test.version_name == "CXXABI_1.3.11"
|| test.version_name == "CXXABI_FLOAT128"
|| test.version_name == "CXXABI_TM_1");