This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [libstdc++,PATCH] src/c++11/snprintf_lite.cc - update bug reporting URL


On 08/02/17 12:02 +0100, Jakub Jelinek wrote:
On Wed, Feb 08, 2017 at 10:58:20AM +0000, Jonathan Wakely wrote:
On 08/02/17 11:50 +0100, Jakub Jelinek wrote:
> On Wed, Feb 08, 2017 at 10:42:58AM +0000, Jonathan Wakely wrote:
> > On 08/02/17 08:17 +0100, Gerald Pfeifer wrote:
> > > Index: src/c++11/snprintf_lite.cc
> > > ===================================================================
> > > --- src/c++11/snprintf_lite.cc	(revision 245267)
> > > +++ src/c++11/snprintf_lite.cc	(working copy)
> > > @@ -52,7 +52,7 @@
> > >     const size_t __len = __bufend - __buf + 1;
> > >
> > >     const char __err[] = "not enough space for format expansion "
> > > -      "(Please submit full bug report at http://gcc.gnu.org/bugs.html):\n    ";
> > > +      "(Please submit full bug report at http://gcc.gnu.org/bugs/):\n    ";
> > >     const size_t __errlen = sizeof(__err) - 1;
> > >
> > >     char *const __e
> >
> > Shouldn't that be https ? :-)
> >
> > I'd welcome better suggestions for how to deal with this error
> > condition (which should never happen) but I can't think of any myself.
>
> ACX_BUGURL([https://gcc.gnu.org/bugs/])
> in configure.ac and then use REPORT_BUGS_TO in the Makefile?
>
> Note ACX_BUGURL in gcc/configure.ac needs adjustments too.

Do we need to worry about an arbitrarily long bugurl causing the
alloca to fail?

I wouldn't, people who configure with 256KB long --with-bugurl arguments
should be adequately punished.

Works for me :-)

This is now https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79422


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]