This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch] Remove variant<void>, variant<T&> and variant<>
- From: Tim Shen <timshen at google dot com>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 15 Nov 2016 11:51:04 -0800
- Subject: Re: [Patch] Remove variant<void>, variant<T&> and variant<>
- Authentication-results: sourceware.org; auth=none
- References: <CAG4ZjNn1K2s=ZfS++pLdZV=qEinMJERraxK8bm2Juf_kRFLNog@mail.gmail.com> <20161115120841.GC3145@redhat.com> <20161115193133.GL3145@redhat.com>
On Tue, Nov 15, 2016 at 11:31 AM, Jonathan Wakely <jwakely@redhat.com> wrote:
> On 15/11/16 12:08 +0000, Jonathan Wakely wrote:
>>
>> On 12/11/16 12:11 -0800, Tim Shen wrote:
>>>
>>> At Issaquah we decided to remove the supports above.
>>
>>
>> OK with a suitable ChangeLog, thanks.
>
>
> I've adjusted your ChangeLog entry to fit under 80 columns with TAB
> set to 8 spaces. I've also adjusted the pretty printer test that was
> using variant<string_view&>.
Thanks! This is how tabstop=2 people have a different view of world
from the rest of us. :)
And I keep forgetting running the whole testsuite. Sorry!
>
> Tested x86_64-linux, committed to trunk.
>
--
Regards,
Tim Shen