Re: [v3 PATCH] Implement std::string_view and P0254r2, Integrating std::string_view and std::string.

[Ville Voutilainen <ville dot voutilainen at gmail dot com>]

On 19 July 2016 at 21:34, Ville Voutilainen <ville.voutilainen@gmail.com> wrote:
> Tested on Linux-x64.
>
> I'm quite sure there are cosmetic issues left in this patch, like in the section
> references of the tests. I will send it out for review now anyway.

I fixed the section references for the tests that add new tests for
basic_string, they are now
correct and mnemonic rather than incorrect and numeric. I also tweaked
the compare implementation a bit based on my discussions with Marshall.

Changelog as it was before, tested on Linux-x64.

I haven't fixed all section references of string tests, and I haven't
added section references
to string_view tests, because they didn't have any. I also haven't
added tests that test the various
exception-throwing cases for the various operations. Doing those changes is
a) going to change many many files
b) probably not urgent
so here's a modest suggestion:
let's put this patch in, and tweak the section references in the other
tests later with separate patches,
as well as add more comprehensive exception-tests.

Ok for trunk?

Attachment: std_string_view_2.diff.gz
Description: GNU Zip compressed data