This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [patch] libstdc++/69703 ignore endianness in codecvt_utf8
- From: Christophe Lyon <christophe dot lyon at linaro dot org>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: "Andre Vieira (lists)" <Andre dot SimoesDiasVieira at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
- Date: Thu, 26 May 2016 14:02:10 +0200
- Subject: Re: [patch] libstdc++/69703 ignore endianness in codecvt_utf8
- Authentication-results: sourceware.org; auth=none
- References: <20160419180305 dot GB3577 at redhat dot com> <20160419180629 dot GC3577 at redhat dot com> <20160419180749 dot GD3577 at redhat dot com> <20160420174028 dot GK3577 at redhat dot com> <572A20FC dot 7080702 at arm dot com> <20160505101224 dot GC27545 at redhat dot com> <CAKdteOZSYG2X7BqFpPOr5SOw3RWo31ChM22v85Q1jcomYKNHhA at mail dot gmail dot com>
On 26 May 2016 at 13:58, Christophe Lyon <christophe.lyon@linaro.org> wrote:
> On 5 May 2016 at 12:12, Jonathan Wakely <jwakely@redhat.com> wrote:
>> On 04/05/16 17:19 +0100, Andre Vieira (lists) wrote:
>>>
>>> On 20/04/16 18:40, Jonathan Wakely wrote:
>>>>
>>>> On 19/04/16 19:07 +0100, Jonathan Wakely wrote:
>>>>>
>>>>> This was reported as a bug in the Filesystem library, but it's
>>>>> actually a problem in the codecvt_utf8 facet that it uses.
>>>>
>>>>
>>>> The fix had a silly typo meaning it didn't work for big endian
>>>> targets, which was revealed by the improved tests I added.
>>>>
>>>> Tested x86_64-linux and powerpc64-linux, committed to trunk.
>>>>
>>>>
>>> Hi Jonathan,
>>>
>>> We are seeing experimental/filesystem/path/native/string.cc fail on
>>> baremetal targets. I'm guessing this is missing a
>>> 'dg-require-filesystem-ts', as seen on other tests like
>>> experimental/filesystem/path/modifiers/swap.cc.
>>>
>>> Cheers,
>>> Andre
>>
>>
>> Sorry about that, I've committed the missing directive.
>>
>>
> Hi,
>
> I've seen you've backported the main patch to the gcc-6 branch, you
> forgot to add the follow-up "Add dg-require-filesystem-ts directive to
> test".
>
And likewise for the gcc-5 branch.
> Christophe