This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Fix detection of setrlimit in libstdc++ testsuite
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: Maxim Kuvyrkov <maxim dot kuvyrkov at linaro dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>, libstdc++ <libstdc++ at gcc dot gnu dot org>
- Date: Fri, 4 Mar 2016 15:27:10 +0000
- Subject: Re: [PATCH] Fix detection of setrlimit in libstdc++ testsuite
- Authentication-results: sourceware.org; auth=none
- References: <28F74808-E037-4192-BB5E-A0492BE31172 at linaro dot org> <9B4A743A-A0A2-4B3F-8564-36685071C1C8 at linaro dot org> <320A223B-8E93-4938-BFA1-E61809101245 at linaro dot org> <E6607920-A264-45DB-A826-81B1A7EE5599 at comcast dot net>
On 02/03/16 09:38 -0800, Mike Stump wrote:
On Mar 2, 2016, at 2:08 AM, Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org> wrote:
PING ^ 2. The patch is sitting without comments for 4+ months.
So the libstdc++ people are usually pretty active and responsive, I usually let them review these sorts of patches as domain experts. I only kick in if they are unreasonably absent. Reviewing the case, I donât see any hint that the libstdc++ list was ever sent an email. You will want to include it in any patches and pings.
Thanks for forwarding this, Mike.
Libstdc++ patches need to be sent to the libstdc++ list, see both
https://gcc.gnu.org/lists.html and
https://gcc.gnu.org/onlinedocs/libstdc++/manual/appendix_contributing.html#list.patches
I don't comment on patches I'm not aware of :-)
I did look at the patch, and it does seem reasonable. Given that the libstdc+ folks never saw it, Iâlll defer to them. You can ping patches once a week, if you would like.
Paolo and I are both attending the WG21 C++ meeting this week. I'm
busy and have not had much time to keep up with email, but I'll review
the patch ASAP.