This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, libstdc++/68863] Let lookahead regex use captured contents


On 14/12/15 09:58 -0800, Tim Shen wrote:
On Mon, Dec 14, 2015 at 3:00 AM, Jonathan Wakely <jwakely@redhat.com> wrote:
I don't fully understand the patch, but it's OK for trunk, and if
you're confident it's definitely correct and safe it's OK for the
gcc-5 and gcc-4_9 branches too.

Was it just completely wrong before, creating a vector of
default-constructed match results, that were not matched?


Yes, that's the case. I'm not sure why I missed this. Perhaps all I
was focusing on is to get the captures in the lookahead sub-expression
out of it, so later user can use it; but I didn't think about the
other way around.

OK then I do understand it and it's definitely OK to commit :-)

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]