This is the mail archive of the
mailing list for the libstdc++ project.
Re: [Testsuite] random shuffle moveable issue
- From: Christopher Jefferson <chris at bubblescope dot net>
- To: Aurelio Remonda <aurelio dot remonda at tallertechnologies dot com>
- Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>
- Date: Sat, 26 Sep 2015 23:15:19 +0100
- Subject: Re: [Testsuite] random shuffle moveable issue
- Authentication-results: sourceware.org; auth=none
- References: <CANLsssva2C=wEEFm8-ixR6eTM7yJgwgLrBRKhEG+gTQSVgddWw at mail dot gmail dot com> <CA+jCFLumLy4OwVS412ePxijFOqyiB_kDHCY15JA0ewnSrF-42A at mail dot gmail dot com> <CANLssstT4NUJt1RtUoYdvHwAJvGSarUm3c9B3-uUH6b7G59yLw at mail dot gmail dot com>
On 25 September 2015 at 22:20, Aurelio Remonda
> El sep 25, 2015 2:12 PM, "Christopher Jefferson" <email@example.com>
>> I assume this means that the board is failing to handle a global
>> variable of int correctly?
>> How small do you have to make the array to make the test pass? The
>> algorithm isn't testing anything specific with an array that big,
>> certainly I imagine 10,000 would be more than enough to get the same
>> quality of test coverage (probably even 100 to be honest, but bigger
>> doesn't hurt).
> Christopher thank you for your reply!
> You can easily make its size of around 30000 so if 10000 is more than enough
> it can
> be done!
> I have a question about the code if you don't mind. Why in the test02 the
> call is needed? If i understood it correctly the random_shuffle is made on
> rv[ ] and then
> it is compared with result [ ]. Am i correct? :)
Yes, that call is pointless. Also, to be honest the test seems a
little sloppy in general -- no real need to make that A a global
variable (although, not clear how much value there is in cleaning
everything up either).