This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, libstdc++] Add specific error message into exceptions

From: Jonathan Wakely <jwakely at redhat dot com>
To: Tim Shen <timshen at google dot com>
Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 7 Sep 2015 12:04:05 +0100
Subject: Re: [Patch, libstdc++] Add specific error message into exceptions
Authentication-results: sourceware.org; auth=none
References: <CAG4ZjNmMzR=V2gWskZjB1LGJWcF9iSztfoz8kLtWfVZfBspsnQ at mail dot gmail dot com> <20150828155946 dot GZ2631 at redhat dot com> <CAG4ZjNnsm1-Ux7f9oXedXSj_wW9nSnCdC+3mGWJpMdJayZsj=Q at mail dot gmail dot com> <CAG4ZjNkVHjxb71G7nSTA77KjD7xMm=_qCTYo+QCS5_NAr-rmDQ at mail dot gmail dot com>

On 28/08/15 20:44 -0700, Tim Shen wrote:

On Fri, Aug 28, 2015 at 11:23 AM, Tim Shen <timshen@google.com> wrote:

So is it good to have an owned raw pointer stored in runtime_error,
pointing to a heap allocated char chunk, which will be deallocated in
regex_error's dtor?


I just put a string member into regex_error, completely ignoring the
storage in std::runtime_error.


That's still an ABI change, so not OK.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]